Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove file uploads feature #501

Merged
merged 4 commits into from
Apr 5, 2023
Merged

Conversation

jasonkuhrt
Copy link
Member

closes #500

@jasonkuhrt jasonkuhrt merged commit 02a5522 into main Apr 5, 2023
@jasonkuhrt jasonkuhrt deleted the improve/no-file-handling branch April 5, 2023 12:19
@anulman
Copy link

anulman commented Apr 10, 2023

Any chance you can release a new version with this fix in it, e.g. v5.2.1 or v5.3.0? I'm having a build fail due to graphql-request's dependency on extract-files:

Failed to resolve entry for package "extract-files". The package may have incorrect main/module/exports specified in its package.json: Missing "." specifier in "extract-files" package

@jasonkuhrt
Copy link
Member Author

@anulman can you confirm that the preview release works for you?

@anulman
Copy link

anulman commented Apr 11, 2023

Looks like it! Builds are succeeding; I'll report back if I see any issues. Tysm 🙏

@avisra
Copy link

avisra commented Apr 13, 2023

this seems like a fairly big regression for users who were dependent on uploading files. how long was that feature in play for before it got removed? I assume if I am currently uploading files through graphql-request, that I should not upgrade the package for awhile?

@jasonkuhrt
Copy link
Member Author

@avisra correct.

@brett-james-rocketlab
Copy link

Seems like a very big feature to take out of the package.

@avisra
Copy link

avisra commented Apr 13, 2023

file upload is an inevitability of building apps today. removing a feature like this, without a workaround, doesn't seem kosher. graphql packages leave a large code footprint - and replacing its implementation with another graphql library (which supports file upload) is not a task that can be completed overnight.

fully aware this is an open source library, and you are free to do with it what you want. but removing a feature like this should really have gone through voting... The issue about removing file upload wasn't even live on github for a week.

@jasonkuhrt
Copy link
Member Author

jasonkuhrt commented Apr 13, 2023

Nothing about what you have today has been broken. If it works for you stick with it. And when the feature returns, if it works for you, use it. PRs welcome guys. Thanks.

@graffle-js graffle-js locked as resolved and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove file handling
4 participants