feat: allow graphql@16 as peer dependency

[vdhpieter]

Closes #299

The other PR was not updated yet, so I tried to give it a go

[vdhpieter]

@jasonkuhrt @GeoffreyHervet could you maybe allow the CI to run so I can at least see if my solution works :)

[vdhpieter]

@jasonkuhrt As you see some workflows failed because minor snapshot changes with GQL v16. I see two options:

• Remove those snapshots (Don't know the codebase well enough to say if they provide a lot of value)
• Add different snapshots for each GQL version, could be done with an env var (shouldn't be to hard) but can become tricky to update these. A script can be written to do the heavy lifting but still would be more cumbersome that it currently is.

What would be your preference? I would be open to look into both :)

[jasonkuhrt]

Snapshots can be given names. I think we can prefix test run with something like GRAPHQL_VERSION=... and then in the snapshot do something like .toMatchSnapshot(process.env.GRAPHQL_VERSION).

[vdhpieter]

@jasonkuhrt I ended up using a snapshotResolver to have different snapshots per version. Otherwise the jest would fail because it found obsolete snapshots.

I also included a small update-snapshots.sh script to easily update all snapshots when needed. Only downside is that it could update the yarn.lock file if there is a new version for graphql@16. On the other hand not bad to keep that one up to date 😉

Let me know what you think and if I need to update anything!

[jasonkuhrt]

LGTM!

[jasonkuhrt]

We can probably drop support for Node 12 in another PR

[vdhpieter]

@jasonkuhrt could you run the tests again?

[vdhpieter]

@jasonkuhrt I was being so stupid... I could also just run the workflow on my own brach before asking you... I did that now and they finally pass! So if you approve one last time we should be good to go!

[jasonkuhrt]

ty!

[vdhpieter]

@jasonkuhrt Any idea when this get's published?

[jasonkuhrt]

@vdhpieter preview releases are there for every trunk commit. Just published a stable though https://github.com/prisma-labs/graphql-request/releases/tag/3.7.0

[vdhpieter]

@jasonkuhrt Thx! just FYI the preview release is broken: https://github.com/prisma-labs/graphql-request/runs/4387187271?check_suite_focus=true

[jasonkuhrt]

@vdhpieter yeah, sigh that error is silly