-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add batching support with batchRequests #285
Conversation
997d867
to
d3ce170
Compare
ee1212f
to
8eccb9f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you try adding a test or two
If this PR could be merged I would be very happy. This feature is all that is missing to give me the go-ahead to use this lib for my project. @GeoffreyHervet is there anything you need? |
8eccb9f
to
6bd40e5
Compare
@sswayney Thanks, I just had to add tests as suggested @jasonkuhrt |
6bd40e5
to
65beda6
Compare
65beda6
to
04ce968
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@GeoffreyHervet Ah, one thing, docs in REDAME would be great thanks! |
@jasonkuhrt I'll add it ! |
Add a new function to support GraphQL batching
closes #13
closes #75