Add agent to client constructor options #130
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like there's some hangup around adding an
agent
property to the constructor options, but I'm not sure I entirely understand it.For instance, Fredy C commented in #84 that:
However, if you like at the typings for the
request
module, they're doing the same thing so I'm not sure what the hangup is?https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/request/index.d.ts#L21