Don't force latest k6 when building extensions #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
an extension will always require k6 and a version of it. It makes little sense to force newer version on users especially as we keep breaking them and we need time to go fix them, but that can only happen after release. This still lets users specify the version (as latest for example) and require the latest k6, it just isn't the default.
This is a bit strange but it turns out that if you have replacements go change how it resolves modules a bit and will try to get the latest versions of some dependencies. Also if you have one extension and you are building it from local sources we would not run `go mod tidy` reliably. This doesn't really matter in practice as we do run it almost every other command, but was getting in the way of smaller fix. Both of those are fixed with this commit and now we do definitely run `go mod tidy` once we have requested all extensions and put down the files needing them. And also only write a file requesting k6 directly at the very end so it only try to get it's version at this point - and at that point we should already have requested through an extension.
|
Needed a bigger fix for when you do Can you guys please test this locally as well - I did a bunch of tests, but still will help if other people try it as well |
This was as there was *possibly* nothing requesting k6 at the time it was setup. Replaces on the other hand stick so XK6_K6_REPO always worked.
imiric
reviewed
May 11, 2022
javaducky
approved these changes
May 11, 2022
Co-authored-by: Ivan Mirić <ivan@loadimpact.com>
imiric
approved these changes
May 11, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
an extension will always require k6 and a version of it. It makes little
sense to force newer version on users especially as we keep breaking
them and we need time to go fix them, but that can only happen after
release.
This still lets users specify the version (as latest for example) and
require the latest k6, it just isn't the default.