Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async Frame #1367

Merged
merged 38 commits into from
Jun 6, 2024
Merged
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
71d8eef
Update Frame.EvaluateHandle to return err
inancgumus Jun 4, 2024
7feeec5
Update Frame.Query to return err
inancgumus Jun 4, 2024
5ec4083
Update Frame.QueryAll to return err
inancgumus Jun 4, 2024
4d28387
Async Frame.check
inancgumus Jun 4, 2024
a366800
Async Frame.content
inancgumus Jun 4, 2024
8161c72
Async Frame.dblclick
inancgumus Jun 4, 2024
6d3f1e6
Async Frame.dispatchEvent
inancgumus Jun 4, 2024
ed30097
Async Frame.evaluate
inancgumus Jun 4, 2024
249c3e5
Async Frame.evaluateHandle
inancgumus Jun 4, 2024
d68359e
Async Frame.fill
inancgumus Jun 4, 2024
bfdc748
Async Frame.focus
inancgumus Jun 4, 2024
16eb5f2
Async Frame.getAttribute
inancgumus Jun 4, 2024
3b51cc2
Async Frame.hover
inancgumus Jun 4, 2024
49266c0
Async Frame.innerHTML
inancgumus Jun 4, 2024
a1ccb79
Async Frame.innerText
inancgumus Jun 4, 2024
54a1812
Async Frame.inputValue
inancgumus Jun 4, 2024
faab189
Async Frame.isChecked
inancgumus Jun 4, 2024
b377711
Async Frame.isDisabled
inancgumus Jun 4, 2024
70d45c7
Async Frame.isEditable
inancgumus Jun 4, 2024
c9a7458
Async Frame.isEnabled
inancgumus Jun 4, 2024
e2ab7f1
Async Frame.isHidden
inancgumus Jun 4, 2024
806ec95
Async Frame.isVisible
inancgumus Jun 4, 2024
8874a27
Async Frame.press
inancgumus Jun 4, 2024
6cac4d9
Async Frame.selectOption
inancgumus Jun 4, 2024
d303b5c
Async Frame.setContent
inancgumus Jun 4, 2024
297a743
Async Frame.setInputFiles
inancgumus Jun 4, 2024
b012e57
Async Frame.textContent
inancgumus Jun 4, 2024
f2a5adc
Async Frame.title
inancgumus Jun 4, 2024
c5de173
Async Frame.type
inancgumus Jun 4, 2024
846787d
Async Frame.uncheck
inancgumus Jun 4, 2024
31916b2
Async Frame.waitForLoadState
inancgumus Jun 4, 2024
f40e06c
Async Frame.waitForSelector
inancgumus Jun 4, 2024
d6f9ca3
Async Frame.waitForTimeout
inancgumus Jun 4, 2024
4761214
Async Frame.query
inancgumus Jun 4, 2024
1a0a640
Async Frame.queryAll
inancgumus Jun 4, 2024
d328f6a
Remove Frame unnecessary goja object mappings
inancgumus Jun 4, 2024
b1b6e9e
Improve null detection in parseRemoteObjectValue
inancgumus Jun 5, 2024
30073cf
Fix async Frame.frameElement mapping
inancgumus Jun 6, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion browser/frame_mapping.go
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,11 @@ func mapFrame(vu moduleVU, f *common.Frame) mapping { //nolint:gocognit,cyclop
return nil, f.Fill(selector, value, opts) //nolint:wrapcheck
})
},
"focus": f.Focus,
"focus": func(selector string, opts goja.Value) *goja.Promise {
return k6ext.Promise(vu.Context(), func() (any, error) {
return nil, f.Focus(selector, opts) //nolint:wrapcheck
})
},
"frameElement": func() (mapping, error) {
inancgumus marked this conversation as resolved.
Show resolved Hide resolved
fe, err := f.FrameElement()
if err != nil {
Expand Down