Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async ElementHandle #1337

Merged
merged 39 commits into from
May 22, 2024
Merged

Async ElementHandle #1337

merged 39 commits into from
May 22, 2024

Conversation

inancgumus
Copy link
Member

What?

#1296

Checklist

  • I have performed a self-review of my code
  • I have added tests for my changes
  • I have commented on my code, particularly in hard-to-understand areas

inancgumus added 21 commits May 20, 2024 15:35
@inancgumus inancgumus added async supports async (promises) breaking PRs that need to be mentioned in the breaking changes section of the release notes mapping k6 browser to Goja mapping related. labels May 20, 2024
@inancgumus inancgumus self-assigned this May 20, 2024
@inancgumus inancgumus mentioned this pull request May 20, 2024
Closed
@inancgumus inancgumus force-pushed the async/elementhandle branch from da38ce1 to eb19bda Compare May 20, 2024 13:10
@inancgumus inancgumus force-pushed the async/elementhandle branch from eb19bda to 99686df Compare May 20, 2024 13:13
@inancgumus inancgumus marked this pull request as ready for review May 20, 2024 13:13
@inancgumus inancgumus requested a review from ankur22 May 20, 2024 13:13
ankur22
ankur22 approved these changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@inancgumus inancgumus merged commit e4582ff into main-async May 22, 2024
14 checks passed
@inancgumus inancgumus deleted the async/elementhandle branch May 22, 2024 11:36
@BrewTestBot BrewTestBot mentioned this pull request Jun 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankur22 ankur22 ankur22 approved these changes

Assignees

@inancgumus inancgumus

Labels
async supports async (promises) breaking PRs that need to be mentioned in the breaking changes section of the release notes mapping k6 browser to Goja mapping related.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inancgumus @ankur22