Add V2 support. #11
Add V2 support. #11
Conversation
| func TestV2E2E(b *testing.T) { | ||
| // BenchmarkV2E2E-20 2504 451484 ns/op | ||
| dir := b.TempDir() | ||
| func TestV2E2E(t *testing.T) { |
There was a problem hiding this comment.
This was a benchmark but it should be a test.
|
Likely not removed for some time (or ever?). We will only support reading existing V1 files and all new files will be written as V2. |
|
At some point if/when this is adopted by more than Alloy we will have semantic versioning that will allow us to better add rules around removing formats if we want. |
|
I'd think that it's a good idea to remove V1 as we're still in experimental stage and it would reduce the codebase size. A few clusters that are testing this now would lose a few minutes of samples, yes, but I think it's a reasonable expectation given the experimental status. |
|
The reason I dont want to remove it is we have some early adopters and they would lose data. I would be open to removing it after a few alloy releases. |
This adds V2 support and makes it the default for walqueue. I did not rename the v1 serialization files/vars since I wanted that to be as locked down and immutable as possible. I was going to remove the marhsal bit but its used by benchmarking.