fix: handle quotes in --tla-str and --ext-str in "tk eval" #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: If a string with a quote was passes to tk eval's --tla-str or --ext-str, things would break in an unexpected fashion. Fix: Properly JSON-quote any given string.
|
Thank you 🙂 Could you please also add a test for this if possible? 🙂 |
zerok
changed the title
Sure. See 69e25fa |
zerok
changed the title
rudo-thomas
added a commit
to rudo-thomas/tanka
that referenced
this pull request
Nov 22, 2024
Convert the flag values to `import/importstr @"verbatim ""quoted"" string"`, pretty much like go-jsonnet does it. Implements grafana#848 Depends on grafana#1237 for the tests.
zerok
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: If a string with a quote was passed to tk eval's --tla-str or --ext-str, things would break in an unexpected fashion.
Fix: Properly JSON-quote any given string.