Refactor pusher to allow multiple implementations #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hides the pusher/Publisher details behind an interface and adds a registry and a feature flag so that multiple implementations can coexist. Signed-off-by: Adrian Serrano <adrisr83@gmail.com>
adriansr
approved these changes
Aug 3, 2023
mem
added a commit
that referenced
this pull request
Sep 5, 2023
* Refactor pusher to allow multiple implementations (#488) * Fix: pass body to HTTP request if specified * Update golangci-lint and gotestsum * Fix: headers object might have extra commas * Fix: use double quotes with JS-escaped strings * Feature: use expression to match specific headers in multiHTTP * Move client logic to its own file * Move metrics to its own file * Export HttpError from prom package * Add condition variable * Add queue * Add SnappyConcatReader * Add errors * Add options * Add tenant pusher * Add publisher * Enable v2 publisher * Assert that TenantManager is a TenantProvider * Add option to run only fast tests * Fix label names, it should be "type" not "target" Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
Merged
mem
added a commit
that referenced
this pull request
Sep 5, 2023
* Refactor pusher to allow multiple implementations (#488) * Fix: pass body to HTTP request if specified * Update golangci-lint and gotestsum * Fix: headers object might have extra commas * Fix: use double quotes with JS-escaped strings * Feature: use expression to match specific headers in multiHTTP * Move client logic to its own file * Move metrics to its own file * Export HttpError from prom package * Add condition variable * Add queue * Add SnappyConcatReader * Add errors * Add options * Add tenant pusher * Add publisher * Enable v2 publisher * Assert that TenantManager is a TenantProvider * Add option to run only fast tests * Fix label names, it should be "type" not "target" Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hides the pusher/Publisher details behind an interface and adds a registry and a feature flag so that multiple implementations can coexist.