Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recent releases are missing assets #956

Closed
mem opened this issue Oct 23, 2024 · 1 comment · Fixed by #976
Closed

Recent releases are missing assets #956

mem opened this issue Oct 23, 2024 · 1 comment · Fixed by #976
Assignees
@mem
Labels
bug Something isn't working

Comments

@mem
Copy link
Contributor

mem commented Oct 23, 2024

We changed something recently that caused assets to not be published correctly:

bad: v0.28.2: https://github.com/grafana/synthetic-monitoring-agent/releases/tag/v0.28.2
good: v0.26.0: https://github.com/grafana/synthetic-monitoring-agent/releases/tag/v0.26.0
@mem mem added the bug Something isn't working label Oct 23, 2024
@nadiamoe
Copy link
Member

Dropping some context: As a part of building linux packages, goreleaser used to sign them with a GPG key. That key is not trivially accessible from GHA using standard shared-workflows.

I asked platform about this in the past here, and they suggested deployment_tools would be the right place to do the signing, and what everybody else publishing packages is doing.

mem added a commit that referenced this issue Nov 5, 2024
@mem
Fix: add packages to release
d536c96 
Use GitHub's command line tool (gh) to add packages to the existing
release. The assumption is that the tag was created because there's a
matching release.

This feels wrong, because we are creating a release and then later, in a
separate workflow, we are adding files to that release, instead of doing
it in a single location. From my point of view, the problem is that we
are conceptually creating a release which creates a tag instead of the
other way around. It's even a little weirder because GitHub does support
the concept of "draft release", but release-please doesn't.

Fixes: #956
Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
@mem mem mentioned this issue Nov 5, 2024
Merged
@mem mem closed this as completed in #976 Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mem mem

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: add packages to release grafana/synthetic-monitoring-agent
2 participants
@mem @nadiamoe