Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go to 1.24 #196

Merged
merged 3 commits into from
Feb 12, 2025
Merged

Update Go to 1.24 #196

merged 3 commits into from
Feb 12, 2025

Conversation

andyasp
Copy link
Collaborator

@andyasp andyasp commented Feb 12, 2025

Release notes: https://go.dev/doc/go1.24

Updated golangci-lint version used in the action because 1.64.2 supports 1.24 (release)

Moved fmt.Sprintf calls outside of the deny function due to an added check in 1.24:

The existing printf analyzer now reports a diagnostic for calls of the form fmt.Printf(s), where s is a non-constant format string, with no other arguments. Such calls are nearly always a mistake as the value of s may contain the % symbol; use fmt.Print instead.

@andyasp andyasp marked this pull request as ready for review February 12, 2025 19:30
Copy link
Contributor

@56quarters 56quarters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andyasp andyasp merged commit 5f472d4 into main Feb 12, 2025
6 checks passed
@andyasp andyasp deleted the aasp/update-go-1.24 branch February 12, 2025 19:47
@andyasp andyasp mentioned this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants