Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osv-scanner is not filtering correctly #85

Merged
merged 2 commits into from
Mar 1, 2023
Merged

Conversation

briangann
Copy link
Collaborator

@briangann briangann commented Feb 28, 2023

Plugin submissions were incorrectly being flagged as have critical vulnerabilities.

  • the packages were not being filtered correctly resulting in packages like simple-git being included in output when it should have been excluded
  • added a "common" type for noisy packages, like underscore
  • updated critical node test yarn.lock to use an old package with a critical vulnerability that can reliably be run in the test

@briangann briangann requested a review from academo February 28, 2023 19:37
@briangann briangann added the bug Something isn't working label Feb 28, 2023
@briangann briangann self-assigned this Feb 28, 2023
Copy link
Member

@academo academo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it is working

@briangann briangann merged commit 4fea532 into main Mar 1, 2023
@briangann briangann deleted the 20230228_update_osv branch March 1, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

2 participants