Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn osv critical and high severity findings into errors #299

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

academo
Copy link
Member

@academo academo commented Jan 8, 2025

No description provided.

@academo academo requested review from a team as code owners January 8, 2025 10:44
@academo academo requested review from oshirohugo, wbrowne and xnyo and removed request for a team January 8, 2025 10:44
Name: "osv-scanner-succeeded",
Severity: analysis.Warning,
}
osvScannerCriticalSeverityDetected = &analysis.Rule{
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ran gofmt in this file. the only changes are this and the next rule are now errors

Copy link
Member

@xnyo xnyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@academo academo merged commit 87b3526 into main Jan 9, 2025
2 checks passed
@academo academo deleted the academo/turn-osv-warning-to-error branch January 9, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants