fix(distributor-ha): Use a no-op HA tracker when not accepting writes #9976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56quarters
force-pushed
the
56quarters/ha-tracker
branch
from
6a32719 to
7a35812
Compare
This changes how the HA tracker in the distributor is initialized. Instead of creating it unconditionally when a distributor is started, use a no-op version when the HA tracker is disabled or when running as part of component that does not accept writes but still uses distributor code like queriers and rulers. Related #9826 Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
56quarters
force-pushed
the
56quarters/ha-tracker
branch
from
7a35812 to
545a40b
Compare
Closed
4 tasks
NickAnge
reviewed
Nov 22, 2024
NickAnge
reviewed
Nov 22, 2024
NickAnge
reviewed
Nov 22, 2024
NickAnge
reviewed
Nov 22, 2024
aldernero
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This changes how the HA tracker in the distributor is initialized. Instead of creating it unconditionally when a distributor is started, use a no-op version when the HA tracker is disabled or when running as part of component that does not accept writes but still uses distributor code like queriers and rulers.
Which issue(s) this PR fixes or relates to
Related #9826
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.