-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dashboards] Unify ingester autoscaling panels on writes dashboard #9617
Conversation
…e if ingester autoscaling is enabled in the config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
$.autoScalingActualReplicas('ingester') + { title: 'Replicas (leader zone)' } + | ||
local replicaTemplateQueries = [ | ||
||| | ||
max by (name) ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nit] Why by (name)
given we don't display the {{ name }}
in the legend?
Same comment applies below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed in d3f4726
Co-authored-by: Marco Pracucci <marco@pracucci.com>
What this PR does
Use a single set of panels on the "Mimir / Writes" dashboard for ingest-storage and standard ingester autoscaling.
Regular autoscaling:

Ingest storage:

Which issue(s) this PR fixes or relates to
Fixes #N/A
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.