Adds bearer token support for mimirtool's analyze ruler/prometheus co… #9587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tacole02
approved these changes
Oct 10, 2024
| | Environment variable | Flag | Description | | ||
| | -------------------- | --------------- | --------------------------------------------------------------------------------------------------- | | ||
| | `MIMIR_ADDRESS` | `--address` | Sets the address of the Prometheus instance. | | ||
| | `MIMIR_TENANT_ID` | `--id` | Sets the basic auth username. If you're using Grafana Cloud, this variable is your instance ID. | |
There was a problem hiding this comment.
Suggested change
| | `MIMIR_TENANT_ID` | `--id` | Sets the basic auth username. If you're using Grafana Cloud, this variable is your instance ID. | | |
| | `MIMIR_TENANT_ID` | `--id` | Sets the basic authentication username. If you're using Grafana Cloud, this variable is your instance ID. | |
| | -------------------- | --------------- | --------------------------------------------------------------------------------------------------- | | ||
| | `MIMIR_ADDRESS` | `--address` | Sets the address of the Prometheus instance. | | ||
| | `MIMIR_TENANT_ID` | `--id` | Sets the basic auth username. If you're using Grafana Cloud, this variable is your instance ID. | | ||
| | `MIMIR_API_KEY` | `--key` | Sets the basic auth password. If you're using Grafana Cloud, this variable is your API key. | |
There was a problem hiding this comment.
Suggested change
| | `MIMIR_API_KEY` | `--key` | Sets the basic auth password. If you're using Grafana Cloud, this variable is your API key. | | |
| | `MIMIR_API_KEY` | `--key` | Sets the basic authentication password. If you're using Grafana Cloud, this variable is your API key. | |
| | `MIMIR_ADDRESS` | `--address` | Sets the address of the Prometheus instance. | | ||
| | `MIMIR_TENANT_ID` | `--id` | Sets the basic auth username. If you're using Grafana Cloud, this variable is your instance ID. | | ||
| | `MIMIR_API_KEY` | `--key` | Sets the basic auth password. If you're using Grafana Cloud, this variable is your API key. | | ||
| | `MIMIR_AUTH_TOKEN` | `--auth-token` | Sets bearer or JWT token that is required for Mimir clusters authenticating by bearer or JWT token. | |
There was a problem hiding this comment.
Suggested change
| | `MIMIR_AUTH_TOKEN` | `--auth-token` | Sets bearer or JWT token that is required for Mimir clusters authenticating by bearer or JWT token. | | |
| | `MIMIR_AUTH_TOKEN` | `--auth-token` | Sets the bearer or JWT token that is required for Mimir clusters authenticating with this method. | |
56quarters
approved these changes
Oct 10, 2024
|
Updated verbiage based on @tacole02 suggestions - made my own commit instead of taking the suggestions just to make sure the table spacing looked right. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mmands
What this PR does
mimirtool has support for authenticating using
--auth-token(since #2146) to supply a bearer token for therulescommand, but theanalyze rulerandanalyze prometheuscommands do not currently support using a bearer token. This PR adds support for that.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.