Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jsonnet/ingest-storage: Make stabilization window for scaling ingesters configurable #9445

Conversation

pstibrany
Copy link
Member

What this PR does

This PR adds ingest_storage_ingester_autoscaling_scale_up_stabilization_window_seconds and ingest_storage_ingester_autoscaling_scale_down_stabilization_window_seconds config options to make stabilization window for ingester autoscaling when using ingest-storage configurable.

Checklist

  • Tests updated.
  • [na] Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

…rage configurable.

Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
@pstibrany pstibrany requested a review from a team as a code owner September 27, 2024 08:51
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Copy link
Contributor

@narqo narqo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

jsonnet-linter isn't happy in the CI, but I agree with the spirit of the changes 🙃

@pstibrany
Copy link
Member Author

jsonnet-linter isn't happy in the CI, but I agree with the spirit of the changes 🙃

I forgot to commit one file :) Now it's fine.

@pstibrany pstibrany merged commit 14be405 into main Sep 27, 2024
29 checks passed
@pstibrany pstibrany deleted the Make-stabilization-window-for-scaling-ingesters-when-using-ingest-storage-configurable branch September 27, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants