Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a metric to track users with newlines in ingested label values #9400

Conversation

colega
Copy link
Contributor

@colega colega commented Sep 25, 2024

What this PR does

Creates an experimental, most likely temporary, metric cortex_distributor_label_values_with_newlines_total used to track tenants who are sending newlines in their label values.

Which issue(s) this PR fixes or relates to

Fixes an internal request

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
@colega colega force-pushed the create-a-metric-to-track-users-with-newlines-in-ingested-label-values branch from 5ffb4b5 to 8209745 Compare September 25, 2024 09:48
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
@colega colega marked this pull request as ready for review September 25, 2024 09:49
@colega colega requested a review from a team as a code owner September 25, 2024 09:49
Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, with minor comments. thanks.

pkg/distributor/distributor.go Outdated Show resolved Hide resolved
pkg/distributor/distributor_test.go Show resolved Hide resolved
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@colega colega merged commit 82c47c8 into main Sep 25, 2024
29 checks passed
@colega colega deleted the create-a-metric-to-track-users-with-newlines-in-ingested-label-values branch September 25, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants