Fix timestamp reported in the "the sample has been rejected because its timestamp is too old" error #8462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts timestamp is too old" error when the write request contains only histograms Signed-off-by: Marco Pracucci <marco@pracucci.com>
pstibrany
approved these changes
Jun 21, 2024
| @@ -10216,7 +10216,7 @@ func TestIngester_PushWithSampledErrors(t *testing.T) { | |||
| errorSampleRate := 5 | |||
| now := time.Now() | |||
|
|
|||
| users := []string{"test", "tset"} | |||
| users := []string{"user-1", "user-2"} | |||
There was a problem hiding this comment.
lol, why would you change that? :)
There was a problem hiding this comment.
Because I don't like get tricked when I look at failed assertions 😉
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
While working on #8431 I noticed that the timestamp reported by "the sample has been rejected because its timestamp is too old" error is the zero value when the write request contains only histograms. This PR fixes it.
Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.