Ingester: add cortex_ingester_circuit_breaker_request_timeouts_total metric #8446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duricanikolic
force-pushed
the
yuri/ingester-server-cb
branch
from
f7cb50c
to
0f44a44
Compare
…metric Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
duricanikolic
force-pushed
the
yuri/ingester-server-cb
branch
from
0f44a44
to
d8d0a18
Compare
pstibrany
approved these changes
Jun 20, 2024
pkg/ingester/circuitbreaker.go
Outdated
| @@ -48,6 +49,11 @@ func newCircuitBreakerMetrics(r prometheus.Registerer, currentState func() circu | |||
| Help: "Results of executing requests via the circuit breaker.", | |||
| ConstLabels: map[string]string{circuitBreakerRequestTypeLabel: requestType}, | |||
| }, []string{"result"}), | |||
| circuitBreakerRequestTimeouts: promauto.With(r).NewCounter(prometheus.CounterOpts{ | |||
| Name: "cortex_ingester_circuit_breaker_request_timeouts_total", | |||
| Help: "Number of times a circuit breaker request reached a timeout.", | |||
There was a problem hiding this comment.
Is it a "circuit breaker request"? Or rather a request that reached timeout, that we registered into circuit breaker.
There was a problem hiding this comment.
I have changed it into "Number of times the circuit breaker recorded a request that reached timeout."
Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
grafanabot
pushed a commit
that referenced
this pull request
Jun 21, 2024
…metric (#8446) * Ingester: add cortex_ingester_circuit_breaker_request_timeouts_total metric Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> * Fixing review findings Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> --------- Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> (cherry picked from commit c279dc5)
dimitarvdimitrov
pushed a commit
that referenced
this pull request
Jun 21, 2024
…metric (#8446) (#8474) * Ingester: add cortex_ingester_circuit_breaker_request_timeouts_total metric Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> * Fixing review findings Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> --------- Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> (cherry picked from commit c279dc5) Co-authored-by: Đurica Yuri Nikolić <durica.nikolic@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR introduces the
cortex_ingester_circuit_breaker_request_timeouts_totalmetrics that keeps track of ingester circuit breaker requests timeouts. These timeouts are relevant for circuit breaker only, and are never returned to distributors. By using this metrics it is possible to verify the number of occurrences of these timeouts.Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.