Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query-tee improvements #8330

Merged
merged 5 commits into from
Jun 14, 2024
Merged

Query-tee improvements #8330

merged 5 commits into from
Jun 14, 2024

Conversation

charleskorn
Copy link
Contributor

@charleskorn charleskorn commented Jun 11, 2024

What this PR does

This PR makes a number of small improvements to query-tee:

  • it reduces the bucket factor of the native histogram metrics introduced in Querytee: Add metric to measure relative backend latency #7782 to give finer granularity
  • it flips the meaning of the metrics introduced in Querytee: Add metric to measure relative backend latency #7782 to make them easier to reason about - I find these easier to think about this way around, as "secondary response time was 102% of preferred response time" or "secondary response time was 0.2s slower than preferred"
  • it modifies backend_response_relative_duration_proportional to report the proportional difference, rather than just the proportional duration, as this gives values closer to 0 and therefore higher resolution

Each of these changes is in its own commit, and I suggest reviewing each commit separately.

Which issue(s) this PR fixes or relates to

(none)

Checklist

  • Tests updated.
  • [n/a] Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • [n/a] about-versioning.md updated with experimental features.

Copy link
Contributor

@jhesketh jhesketh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I agree this is easier to reason with, and since this hasn't been released yet I think it's fine to change at this point.

Only thing missing is docs/sources/mimir/manage/tools/query-tee.md needs updating please.

@charleskorn charleskorn marked this pull request as ready for review June 13, 2024 03:27
@charleskorn charleskorn requested review from a team and jdbaldry as code owners June 13, 2024 03:27
Copy link
Contributor

@jhesketh jhesketh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding docs :-)

@charleskorn charleskorn merged commit 06301d9 into main Jun 14, 2024
29 checks passed
@charleskorn charleskorn deleted the charleskorn/query-tee-improvements branch June 14, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants