Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jsonnet: set -ingest-storage.kafka.consumer-group-offset-commit-interval=5s #8222

Merged
merged 1 commit into from
May 30, 2024

Conversation

pracucci
Copy link
Collaborator

What this PR does

In this PR I'm upstreaming a config I've tested in our test envs: set -ingest-storage.kafka.consumer-group-offset-commit-interval=5s in ingesters when running experimental ingest storage. I introduced this config option in #8135. The default value is 1s, I'm increasing it to 5s, which means OffsetCommit rate will decrease by a 5x factor.

Which issue(s) this PR fixes or relates to

N/A

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

…val=5s in ingesters when running experimental ingest storage

Signed-off-by: Marco Pracucci <marco@pracucci.com>
@pracucci pracucci marked this pull request as ready for review May 30, 2024 14:53
@pracucci pracucci requested a review from a team as a code owner May 30, 2024 14:53
Copy link
Contributor

@56quarters 56quarters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pracucci pracucci merged commit c0947a8 into main May 30, 2024
29 checks passed
@pracucci pracucci deleted the upstream-consumer-group-offset-commit-interval branch May 30, 2024 15:34
narqo pushed a commit to narqo/grafana-mimir that referenced this pull request Jun 6, 2024
…val=5s in ingesters when running experimental ingest storage (grafana#8222)

Signed-off-by: Marco Pracucci <marco@pracucci.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants