Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MimirIngesterStuckProcessingRecordsFromKafka alert #8147

Merged
merged 3 commits into from
May 21, 2024

Conversation

pracucci
Copy link
Collaborator

What this PR does

Earlier today we've found an issue in a staging environment causing the ingestion from Kafka to be stuck (due to a deadlock). It took a long time to figure it out and none of the existing alerts fired. This alert may have helped.

Which issue(s) this PR fixes or relates to

N/A

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
@pracucci pracucci marked this pull request as ready for review May 15, 2024 15:53
@pracucci pracucci requested review from jdbaldry and a team as code owners May 15, 2024 15:53
Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you. I'll apply my nit-fixes and merge.

docs/sources/mimir/manage/mimir-runbooks/_index.md Outdated Show resolved Hide resolved
docs/sources/mimir/manage/mimir-runbooks/_index.md Outdated Show resolved Hide resolved
@pstibrany pstibrany enabled auto-merge (squash) May 21, 2024 08:05
@pstibrany pstibrany merged commit 7b811fd into main May 21, 2024
31 checks passed
@pstibrany pstibrany deleted the add-alert-if-kafka-ingestion-is-stuck branch May 21, 2024 08:22
francoposa pushed a commit that referenced this pull request May 27, 2024
* Add MimirIngesterStuckProcessingRecordsFromKafka alert

Signed-off-by: Marco Pracucci <marco@pracucci.com>

* Added CHANGELOG entry

Signed-off-by: Marco Pracucci <marco@pracucci.com>

* Apply suggestions from code review

---------

Signed-off-by: Marco Pracucci <marco@pracucci.com>
Co-authored-by: Peter Štibraný <pstibrany@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants