distributor: allow enforcing maximum buffer size for write request pool #8082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ortuman
force-pushed
the
ortuman/use-bucketed-buffers-in-util-request-buffers
branch
15 times, most recently
from
0dad20e
to
48f2395
Compare
ortuman
changed the title
util.RequestsBuffers
ortuman
changed the title
colega
reviewed
May 9, 2024
colega
reviewed
May 9, 2024
colega
reviewed
May 9, 2024
colega
reviewed
May 9, 2024
colega
reviewed
May 9, 2024
ortuman
force-pushed
the
ortuman/use-bucketed-buffers-in-util-request-buffers
branch
from
bd69180
to
ba524a2
Compare
ortuman
changed the title
colega
reviewed
May 9, 2024
colega
approved these changes
May 9, 2024
Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com>
Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com>
Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com>
ref: #8082 (comment) Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com>
ref: #8082 (comment) Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com>
ref: #8082 (comment) Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com>
ref: #8082 (comment) Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com>
ref: #8082 (comment) Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com>
ref: https://github.com/grafana/mimir/actions/runs/9020096103/job/24784496196?pr=8082 Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com>
ortuman
force-pushed
the
ortuman/use-bucketed-buffers-in-util-request-buffers
branch
from
a2ae178
to
e298f7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR adds a new experimental CLI parameter called
-distributor.max-request-pool-buffer-sizethat allows enforcing a maximum size in bytes for the pool buffers used for decompressing request bodies in both Prometheus and OTLP handlers. By default, this is set to0, which means no maximum will be enforced (same behavior as currently).Additionally, a new metric named
cortex_distributor_uncompressed_request_body_size_byteshas been included in order to provide visibility on the average of uncompressed body payload, thus allowing for an informed decision to be made when setting the previously mentioned maximum.Which issue(s) this PR fixes or relates to
Fixes N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.