Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dskit #7784

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Update dskit #7784

merged 2 commits into from
Apr 3, 2024

Conversation

pracucci
Copy link
Collaborator

@pracucci pracucci commented Apr 3, 2024

What this PR does

Updating dskit to get:

In particular, there are 2 significant changes:

  • ShoudLog() signature has changed. A sampled error should not be wrapped anymore to add sampled 1/n suffix, because the suffix is added downstream, if and only if it was actually sampled. Fixes Some ingester error logs are incorrectly noted as "sampled" #7690
  • Add outcome label to cortex_bucket_stores_gate_duration_seconds histogram metric

Which issue(s) this PR fixes or relates to

Fixes #7690
Part of #5894

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@pracucci pracucci marked this pull request as ready for review April 3, 2024 10:25
@pracucci pracucci requested review from grafanabot and a team as code owners April 3, 2024 10:25
@pracucci
Update dskit
1559e5d 
Signed-off-by: Marco Pracucci <marco@pracucci.com>
dimitarvdimitrov
dimitarvdimitrov approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@pracucci pracucci enabled auto-merge (squash) April 3, 2024 11:49
@pracucci pracucci merged commit 050b083 into main Apr 3, 2024
29 checks passed
@pracucci pracucci deleted the update-dskit branch April 3, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimitarvdimitrov dimitarvdimitrov dimitarvdimitrov approved these changes

@pstibrany pstibrany pstibrany approved these changes

@grafanabot grafanabot Awaiting requested review from grafanabot grafanabot is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some ingester error logs are incorrectly noted as "sampled"
3 participants
@pracucci @pstibrany @dimitarvdimitrov