Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

continuous-test docker binary swap #7753

Merged
merged 6 commits into from
Apr 4, 2024
Merged

Conversation

johannaratliff
Copy link
Contributor

@johannaratliff johannaratliff commented Mar 29, 2024

What this PR does

Replaces the mimir-continuous-test binary usage in the grafana/mimir-continuous-test docker image with the mimir binary and calling the continuous-test module.

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@johannaratliff johannaratliff reopened this Apr 1, 2024
@johannaratliff johannaratliff marked this pull request as ready for review April 3, 2024 21:35
Copy link
Contributor

@56quarters 56quarters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a warning log line to the existing continuous test binary?

CHANGELOG.md Outdated Show resolved Hide resolved
@@ -47,6 +47,7 @@

### Mimir Continuous Test

+* [CHANGE] `mimir-continuous-test` has been deprecated and replaced by a Mimir module that can be run as a target from the `mimir` binary using `mimir -target=continuous-test`. #7753
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog seems to have grown an errant +

Suggested change
+* [CHANGE] `mimir-continuous-test` has been deprecated and replaced by a Mimir module that can be run as a target from the `mimir` binary using `mimir -target=continuous-test`. #7753
* [CHANGE] `mimir-continuous-test` has been deprecated and replaced by a Mimir module that can be run as a target from the `mimir` binary using `mimir -target=continuous-test`. #7753

@johannaratliff johannaratliff merged commit 71470a7 into main Apr 4, 2024
29 checks passed
@johannaratliff johannaratliff deleted the continuous-test-docker-image branch April 4, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants