Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboards: renamed rows in the "Remote ruler reads" and "Remote ruler reads resources" dashboards to match the actual component names #7750

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

pracucci
Copy link
Collaborator

What this PR does

I'm working on some improvements to "Remote ruler" dashboards and I noticed the row titles are a bit confusing. The Mimir components have a specific name (e.g. ruler-query-frontend, ruler-query-scheduler, ...) so I think we should just use it.

Example of dashboards after these changes are applied:

screencapture-localhost-3001-d-1940f6ef765a506a171faa2056c956c3-mimir-remote-ruler-reads-resources-2024-03-29-10_24_26

screencapture-localhost-3001-d-f103238f7f5ab2f1345ce650cbfbfe2f-mimir-remote-ruler-reads-2024-03-29-10_24_17

Which issue(s) this PR fixes or relates to

N/A

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@pracucci pracucci marked this pull request as ready for review March 29, 2024 09:24
@pracucci pracucci requested a review from a team as a code owner March 29, 2024 09:24
Copy link
Contributor

@ying-jeanne ying-jeanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…r reads resources" dashboards to match the actual component names

Signed-off-by: Marco Pracucci <marco@pracucci.com>
@pracucci pracucci force-pushed the rename-rows-in-remote-ruler-dashboards branch from 3dd46ce to eda51f6 Compare April 2, 2024 09:11
@pracucci pracucci enabled auto-merge (squash) April 2, 2024 09:12
@pracucci pracucci merged commit 8f99ae9 into main Apr 2, 2024
31 checks passed
@pracucci pracucci deleted the rename-rows-in-remote-ruler-dashboards branch April 2, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants