Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboards: Update regex that matches read-path related gRPC methods on ingesters #7676

Merged
merged 6 commits into from
Mar 21, 2024

Conversation

pstibrany
Copy link
Member

What this PR does

This PR updates regex that matches read-path related gRPC methods on ingesters. Some previously missing methods were added:

  • /cortex.Ingester/QueryExemplars
  • /cortex.Ingester/LabelNames
  • /cortex.Ingester/UserStats
  • /cortex.Ingester/AllUserStats
  • /cortex.Ingester/LabelNamesAndValues
  • /cortex.Ingester/LabelValuesCardinality
  • /cortex.Ingester/ActiveSeries

All these are read-path queries, but were not accounted for in various dashboards.

Checklist

  • [na] Tests updated.
  • [na] Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • [na] about-versioning.md updated with experimental features.

Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
@pstibrany pstibrany requested a review from a team as a code owner March 20, 2024 15:58
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I would suggest adding a comment to service Ingester in pkg/ingester/client/ingester.proto to update this regex each time we add more methods.

…ing more read-path methods.

Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
@pstibrany pstibrany enabled auto-merge (squash) March 20, 2024 16:45
@pstibrany pstibrany merged commit fc00647 into main Mar 21, 2024
31 checks passed
@pstibrany pstibrany deleted the read-grpc-methods branch March 21, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants