Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc updates about Compactor storage as it relates to Kubernetes #7675

Merged
merged 8 commits into from
Mar 28, 2024

Conversation

seizethedave
Copy link
Contributor

@seizethedave seizethedave commented Mar 20, 2024

What this PR does

Add docs clarifying the kind of volume to use for compactor's data-dir, and add a note about why compactor should use a StatefulSet.

Which issue(s) this PR fixes or relates to

Fixes #3061

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@CLAassistant
Copy link

CLAassistant commented Mar 20, 2024

CLA assistant check
All committers have signed the CLA.

@seizethedave seizethedave marked this pull request as ready for review March 20, 2024 18:33
@seizethedave seizethedave requested review from jdbaldry and a team as code owners March 20, 2024 18:33
Copy link
Contributor

@56quarters 56quarters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'll let the docs team 👍

@jhalterman jhalterman added the type/docs Improvements or additions to documentation label Mar 20, 2024
Copy link
Member

@jdbaldry jdbaldry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution

@seizethedave seizethedave changed the title Doc updates about storage, persistent disks, statefulsets. Doc updates about Compactor storage as it relates to Kubernetes Mar 28, 2024
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! LGTM 👏

@pracucci pracucci merged commit 3860f41 into main Mar 28, 2024
29 checks passed
@pracucci pracucci deleted the davidgrant/3061 branch March 28, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Clarify why it's recommended deploy compactor as StatefulSet
6 participants