Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade mimir-prometheus #7656

Merged
merged 3 commits into from
Mar 21, 2024
Merged

Upgrade mimir-prometheus #7656

merged 3 commits into from
Mar 21, 2024

Conversation

charleskorn
Copy link
Contributor

@charleskorn charleskorn commented Mar 19, 2024 •
edited
Loading

What this PR does

This PR upgrades mimir-prometheus to include the changes from grafana/mimir-prometheus#607.

The description of that PR includes a summary of the changes, which I won't repeat here.

Which issue(s) this PR fixes or relates to

(none)

Checklist

  • [n/a] Tests updated.
  • [n/a] Documentation added.
  • [n/a] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • [n/a] about-versioning.md updated with experimental features.

@charleskorn charleskorn marked this pull request as ready for review March 19, 2024 10:53
@charleskorn charleskorn requested review from grafanabot and a team as code owners March 19, 2024 10:53
56quarters
56quarters approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@56quarters 56quarters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

aknuds1
aknuds1 reviewed Mar 20, 2024
View reviewed changes
Copy link
Contributor

@aknuds1 aknuds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure that the following change shouldn't go into the changelog?

TSDB: Fix the predicate checking for blocks which are beyond the retention period to include the ones right at the retention boundary.

@charleskorn
Copy link
Contributor Author

Are you sure that the following change shouldn't go into the changelog?

TSDB: Fix the predicate checking for blocks which are beyond the retention period to include the ones right at the retention boundary.

Good point, added in faafb55

@charleskorn charleskorn enabled auto-merge (squash) March 21, 2024 00:09
@charleskorn charleskorn merged commit c35d888 into main Mar 21, 2024
29 checks passed
@charleskorn charleskorn deleted the charleskorn/upgrade-prometheus branch March 21, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknuds1 aknuds1 aknuds1 left review comments

@56quarters 56quarters 56quarters approved these changes

@grafanabot grafanabot Awaiting requested review from grafanabot grafanabot is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@charleskorn @aknuds1 @56quarters