Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor mimir-prometheus #7624

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Conversation

jhalterman
Copy link
Member

@jhalterman jhalterman commented Mar 14, 2024

What this PR does

Vendor mimir-prometheus to bring in changes from grafana/mimir-prometheus#606.

Which issue(s) this PR fixes or relates to

Relates to https://github.com/grafana/mimir-squad/issues/1936

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@jhalterman jhalterman requested review from grafanabot and a team as code owners March 14, 2024 00:14
Copy link
Contributor

@charleskorn charleskorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Does this need a changelog entry? Based on the description in grafana/mimir-prometheus#606, it sounds like this is not changing any observable behaviour, but if not, would be good to add an entry explaining what this fixes.

@jhalterman jhalterman merged commit 9d6f6d5 into grafana:main Mar 14, 2024
29 checks passed
@jhalterman jhalterman deleted the vendor-mimir-prom branch March 14, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants