store-gateway: record request ambient time for LabelNames and LabelValues #7622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lues The ambient time (`queryStats.streamingSeriesAmbientTime`) is used to observe the `"other"` stage duration in `BucketStore.recordStreamingSeriesStats` after running LabelNames, LabelValues and Series requests. But `queryStats.streamingSeriesAmbientTime` is only populated for `Series` requests. This results in skewed `"other"` timings. Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
…names-and-label-values-requests
dimitarvdimitrov
deleted the
dimitar/st-gw/record-ambient-time-for-label-names-and-label-values-requests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ambient time (
queryStats.streamingSeriesAmbientTime) is used to observe the"other"stage duration inBucketStore.recordStreamingSeriesStatsafter running LabelNames, LabelValues and Series requests.But
queryStats.streamingSeriesAmbientTimeis only populated forSeriesrequests. This results in skewed"other"timings.