Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store-gateway: record waiting at query gate as request stage #7609

Conversation

dimitarvdimitrov
Copy link
Contributor

What this PR does

This PR adds {stage="wait_max_concurrent"} to cortex_bucket_store_series_request_stage_duration_seconds.

See #7608 for more details

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

This PR adds `{stage="wait_max_concurrent"}` to `cortex_bucket_store_series_request_stage_duration_seconds`.

See 7608 for more details

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
@dimitarvdimitrov dimitarvdimitrov requested a review from a team as a code owner March 12, 2024 17:07
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Copy link
Contributor

@56quarters 56quarters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice improvement!

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
@dimitarvdimitrov dimitarvdimitrov enabled auto-merge (squash) March 15, 2024 10:01
@dimitarvdimitrov dimitarvdimitrov merged commit 947b12e into main Mar 15, 2024
29 checks passed
@dimitarvdimitrov dimitarvdimitrov deleted the dimitar/st-gw/add-gate-wait-duration-on-on-request-stages branch March 15, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants