Add partitions support to Distributor.ActiveSeries() #7404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
commented
Feb 16, 2024
| @@ -295,7 +297,7 @@ func TestDistributor_UserStats_ShouldSupportIngestStorage(t *testing.T) { | |||
| makeWriteRequest(0, 1, 0, false, false, "series_1"), | |||
| makeWriteRequest(0, 1, 0, false, false, "series_2"), | |||
| makeWriteRequest(0, 1, 0, false, false, "series_3", "series_4"), | |||
| makeWriteRequest(0, 1, 0, false, false, "series_5", "series_7"), | |||
| makeWriteRequest(0, 1, 0, false, false, "series_5", "series_6"), | |||
There was a problem hiding this comment.
Note to reviewers: I found this (repeated) error in the tests I've merged in my last PR. The result of the test doesn't change due to how UserStats() works (it just aggregate the count of series per ingester), but I wanted to fix it for correctness.
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
changed the title
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Similarly to previous PRs #7393 and #7402, in this PR I'm adding partitions support to
Distributor.ActiveSeries(). This was an easy one. Just a bunch of tests.Note to reviewers:
forReplicationSet()Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.