Remove errors.Cause() usage from cardinality analysis handler #7214
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
In this PR I'm removing
errors.Cause()
fromrespondFromError()
, which is only used by the cardinality analysis handler. Theerrors.Cause()
was passed tohttpgrpc.HTTPResponseFromError()
which, in turn, passes the error togrpcutil.ErrorToStatus()
.grpcutil.ErrorToStatus()
(see code) useserrors.As()
(which navigates the chain of wrapped errors), so theerrors.Cause()
usage should be superfluous.Note: this PR is part of a work I'm doing to completely remove errors.Cause() from Mimir.
Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.