Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update values.yaml documentation and example #7135

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

benoitschipper
Copy link
Contributor

The documentation on the website was not that clear and it took us a while in order to find the http insecure_skip_verify option. Therefore we thought an Example would be good for future reference.

What this PR does

See Commit Message above

Which issue(s) this PR fixes or relates to

N/A

Fixes #

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

The documentation on the website was not that clear and it took us a while in order to find the http insecure_skip_verify option. Therefore we thought an Example would be good for future reference.
@benoitschipper benoitschipper requested a review from a team as a code owner January 15, 2024 20:35
@CLAassistant
Copy link

CLAassistant commented Jan 15, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice to see you again! Thanks for writing this up :) I have a minor comment about placement of this example. Otherwise LGTM

operations/helm/charts/mimir-distributed/values.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@benoitschipper
Copy link
Contributor Author

This current Merge Block has nothing to do with my addition right? Just wanted to confirm :) @dimitarvdimitrov

@dimitarvdimitrov
Copy link
Contributor

This current Merge Block has nothing to do with my addition right? Just wanted to confirm :) @dimitarvdimitrov

The one in integration is a flaky test 😞 #4857

I think you've left some trailing spaces in the comment. Can you clean them up? 🥺

Screenshot 2024-01-17 at 16 20 00

auto-merge was automatically disabled January 18, 2024 06:24

Head branch was pushed to by a user without write access

@benoitschipper
Copy link
Contributor Author

Should be good now :)

@dimitarvdimitrov dimitarvdimitrov enabled auto-merge (squash) January 18, 2024 09:43
@dimitarvdimitrov dimitarvdimitrov enabled auto-merge (squash) January 18, 2024 09:43
@dimitarvdimitrov dimitarvdimitrov merged commit 409da4d into grafana:main Jan 18, 2024
30 checks passed
@benoitschipper benoitschipper deleted the patch-1 branch January 18, 2024 10:34
@benoitschipper
Copy link
Contributor Author

Tx :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants