-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update values.yaml documentation and example #7135
Conversation
The documentation on the website was not that clear and it took us a while in order to find the http insecure_skip_verify option. Therefore we thought an Example would be good for future reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice to see you again! Thanks for writing this up :) I have a minor comment about placement of this example. Otherwise LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
This current Merge Block has nothing to do with my addition right? Just wanted to confirm :) @dimitarvdimitrov |
The one in integration is a flaky test 😞 #4857 I think you've left some trailing spaces in the comment. Can you clean them up? 🥺 |
Head branch was pushed to by a user without write access
Should be good now :) |
Tx :) |
The documentation on the website was not that clear and it took us a while in order to find the http insecure_skip_verify option. Therefore we thought an Example would be good for future reference.
What this PR does
See Commit Message above
Which issue(s) this PR fixes or relates to
N/A
Fixes #
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.