Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler queue benchmark: factor out & clarify functions #7101

Conversation

francoposa
Copy link
Member

@francoposa francoposa commented Jan 10, 2024

Will be adding a benchmark test to prove out the effects of the query scheduler additional queue dimensions when there is a slow querier - factoring out some methods here first to make this more reusable and easier to understand.

What this PR does

Which issue(s) this PR fixes or relates to

Fixes #

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@francoposa francoposa marked this pull request as ready for review January 10, 2024 23:39
@francoposa francoposa requested a review from a team as a code owner January 10, 2024 23:39
Copy link
Contributor

@charleskorn charleskorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francoposa francoposa merged commit a3949ba into main Jan 11, 2024
28 checks passed
@francoposa francoposa deleted the francoposa/query-scheduler-benchmark-multidimensional-queuing-effectiveness branch January 11, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants