Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase default Jaeger queue size for some components and make queue size for all components configurable in Helm chart #7086

Merged
merged 5 commits into from
Jan 10, 2024
Merged

Increase default Jaeger queue size for some components and make queue size for all components configurable in Helm chart #7086

merged 5 commits into from
Jan 10, 2024

Conversation

charleskorn
Copy link
Contributor

@charleskorn charleskorn commented Jan 10, 2024 •
edited
Loading

What this PR does

This PR upstreams a number of changes we've been using internally at Grafana Labs:

  • it increases the Jaeger queue size for ingesters, rulers and query-frontends when using microservices mode
  • it increases the Jaeger queue size for backend and write instances when using read-write mode
  • it expands the pattern established in Increase default Jaeger queue size for store-gateways and queriers #7068 of providing a jaegerReporterMaxQueueSize Helm value for each component where configuring this makes sense

Which issue(s) this PR fixes or relates to

(none)

Checklist

  • Tests updated.
  • [n/a] Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • [n/a] about-versioning.md updated with experimental features.

@charleskorn charleskorn marked this pull request as ready for review January 10, 2024 03:58
@charleskorn charleskorn requested a review from a team as a code owner January 10, 2024 03:58
dimitarvdimitrov
dimitarvdimitrov approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

helm changes LGTM

@charleskorn charleskorn merged commit c5e5014 into main Jan 10, 2024
30 checks passed
@charleskorn charleskorn deleted the charleskorn/jaeger-queue-size branch January 10, 2024 23:53
@eyenx eyenx mentioned this pull request May 28, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimitarvdimitrov dimitarvdimitrov dimitarvdimitrov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charleskorn @dimitarvdimitrov