Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support active count_method in label names cardinality #7085

Merged
merged 12 commits into from
Jan 12, 2024

Conversation

Logiraptor
Copy link
Contributor

@Logiraptor Logiraptor commented Jan 9, 2024

What this PR does

In #5136, we added the count_method param to the label values cardinality API. This PR does the same for the label names cardinality API. This is useful for determining which labels contribute the most towards high active series cardinality.

Which issue(s) this PR fixes or relates to

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • [N/A] about-versioning.md updated with experimental features.

@Logiraptor Logiraptor marked this pull request as ready for review January 10, 2024 20:22
@Logiraptor Logiraptor requested review from a team as code owners January 10, 2024 20:22
Copy link
Contributor

@flxbk flxbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Show resolved Hide resolved
pkg/ingester/ingester.go Outdated Show resolved Hide resolved
@Logiraptor Logiraptor enabled auto-merge (squash) January 12, 2024 22:48
@Logiraptor Logiraptor merged commit 7ce863f into main Jan 12, 2024
28 checks passed
@Logiraptor Logiraptor deleted the logiraptor/active-names-and-values branch January 12, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants