Update MAINTAINERS.md #7077
Merged
Update MAINTAINERS.md #7077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jdbaldry
reviewed
Jan 10, 2024
There was a problem hiding this comment.
My thoughts are that it makes sense to remove Ursula because I do not believe she will be continuing to maintain these docs.
I would not add yourself as a maintainer unless you intend to be added to the @grafana/docs-metrics team and take up the responsibilities of maintainership. Primarily, that is reviewing PRs that affect the files owned by @grafana/docs-metrics
|
Yeah, not my intent to be a maintainer for that reason -- we had thought
perhaps that I should try to get a list of which issues were assigned to
Ursula and assign them to me instead so that, when the new tech writer
arrives, we'd be able to easily re-assign them to her or him.
…On Wed, Jan 10, 2024 at 7:31 AM Jack Baldry ***@***.***> wrote:
***@***.**** commented on this pull request.
My thoughts are that it makes sense to remove Ursula because I do not
believe she will be continuing to maintain these docs.
I would not add yourself as a maintainer unless you intend to be added to
the @grafana/docs-metrics
<https://github.com/orgs/grafana/teams/docs-metrics> team and take up the
responsibilities of maintainership. Primarily, that is reviewing PRs that
affect the files owned by @grafana/docs-metrics
<https://github.com/orgs/grafana/teams/docs-metrics>
—
Reply to this email directly, view it on GitHub
<#7077 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOS4KDK7IL2TUJV7JISNXITYN2CYVAVCNFSM6AAAAABBSDFM5GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMJTGEZDCNRXHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
jdbaldry
reviewed
Jan 18, 2024
There was a problem hiding this comment.
In that case @derek-cadzow I think my suggestion does what you want and if you accept it, we can close and merge this PR.
Co-authored-by: Jack Baldry <jack.baldry@grafana.com>
jdbaldry
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Removes departed employee and substitutes my own ID (Derek Cadzow) until a backfill is in place.
(Jack: not sure I should be a maintainer over the long term - can we discuss? Is this a good idea?)