Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ingest consumer: commit offset on shutdown #6974

Merged
merged 3 commits into from
Dec 20, 2023
Merged

ingest consumer: commit offset on shutdown #6974

merged 3 commits into from
Dec 20, 2023

Conversation

dimitarvdimitrov
Copy link
Contributor

This makes double consumption less likely

@dimitarvdimitrov
ingest consumer: commit offset on shutdown
e4c8311 
This makes double consumption less likely

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
@dimitarvdimitrov dimitarvdimitrov requested a review from a team as a code owner December 20, 2023 11:03
@dimitarvdimitrov
satisfy linter
559b4da 
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
pracucci
pracucci approved these changes Dec 20, 2023
View reviewed changes
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I left a couple of minor comments.

pkg/storage/ingest/reader.go Outdated Show resolved Hide resolved
pkg/storage/ingest/reader.go Outdated Show resolved Hide resolved
@dimitarvdimitrov
Address PR comments
39c8ab6 
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
pracucci
pracucci approved these changes Dec 20, 2023
View reviewed changes
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dimitarvdimitrov dimitarvdimitrov merged commit 1b094a8 into main Dec 20, 2023
28 checks passed
@dimitarvdimitrov dimitarvdimitrov deleted the dimitar/ingest/consumer-commit-offset-on-shutdown branch December 20, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pracucci pracucci pracucci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dimitarvdimitrov @pracucci