TestQuerierWithBlocksStorageOnMissingBlocksFromStorage: start compactor earlier #6815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or earlier This test is a little bit flaky. Starting the compactor first, so it can do its user cleanup on startup, makes sure the store-gateway can discover the bucket index. Otherwise, if the compactro startup takes longer than 1-2 seconds, the store-gateway can discover the blocks Follow-up of 6779 Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
grafanabot
pushed a commit
that referenced
this pull request
Dec 6, 2023
…or earlier (#6815) This test is a little bit flaky. Starting the compactor first, so it can do its user cleanup on startup, makes sure the store-gateway can discover the bucket index. Otherwise, if the compactro startup takes longer than 1-2 seconds, the store-gateway can discover the blocks Follow-up of 6779 Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> (cherry picked from commit 177c17e)
pr00se
pushed a commit
that referenced
this pull request
Dec 6, 2023
…or earlier (#6815) (#6841) This test is a little bit flaky. Starting the compactor first, so it can do its user cleanup on startup, makes sure the store-gateway can discover the bucket index. Otherwise, if the compactro startup takes longer than 1-2 seconds, the store-gateway can discover the blocks Follow-up of 6779 Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> (cherry picked from commit 177c17e) Co-authored-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is a little bit flaky. Starting the compactor first, so it can do its user cleanup on startup, makes sure the store-gateway can discover the bucket index. Otherwise, if the compactro startup takes longer than 1-2 seconds, the store-gateway can discover the blocks
Follow-up of #6779