Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run make mixin-screenshots #6771

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Run make mixin-screenshots #6771

merged 2 commits into from
Dec 1, 2023

Conversation

leizor
Copy link
Contributor

@leizor leizor commented Nov 28, 2023

What this PR does

Run make mixin-screenshots.

Which issue(s) this PR fixes or relates to

#6670

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@leizor leizor requested review from a team as code owners November 28, 2023 22:57
Copy link
Contributor

@56quarters 56quarters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock. Looks good except for the Queries dashboard

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the Queue length (per user) panels here right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also looks like the Bucket indexes loaded panels are empty, I think due to a recent refactoring. I think we should use the existing image here or fix the issue with the bucket indexes metric.

@leizor leizor merged commit 1ee593c into main Dec 1, 2023
28 checks passed
@leizor leizor deleted the leizor/prep-release-2.11 branch December 1, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants