Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.10] Backport native histograms documentation #6757

Merged
merged 5 commits into from
Nov 28, 2023

Conversation

krajorama
Copy link
Contributor

What this PR does

We want to release the docs sooner than 2.11.
Removed mention of resolution reduction on ingest, since that is a 2.11 feature.

Which issue(s) this PR fixes or relates to

Fixes #

Checklist

  • N/A Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • N/A about-versioning.md updated with experimental features.

We want to release the docs sooner than 2.11.
Removed mention of resolution reduction on ingest, since that is a 2.11
feature.

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
@krajorama krajorama requested review from a team as code owners November 28, 2023 08:35
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>

To enable Prometheus remote write to send native histograms to Grafana Mimir, add the `send_native_histograms: true` parameter to your remote write configuration, for example:
To limit the number of native histogram buckets per sample, set the `-validation.max-native-histogram-buckets` flag on distributors.
The recommended value is 160 which is the default in the [OpenTelemetry SDK](https://opentelemetry.io/docs/specs/otel/metrics/sdk/) for exponential histograms, which are a similar concept in OpenTelemetry.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The recommended value is 160 which is the default in the [OpenTelemetry SDK](https://opentelemetry.io/docs/specs/otel/metrics/sdk/) for exponential histograms, which are a similar concept in OpenTelemetry.
The recommended value is `160`, which is the default in the [OpenTelemetry SDK](https://opentelemetry.io/docs/specs/otel/metrics/sdk/) for exponential histograms. The native histogram buckets are similar in concept to exponential histograms in OpenTelemetry.

Spell out that last sentence. Please vet this for technical accuracy, because my change is a guess and has high potential for being inaccurate in this case.

krajorama and others added 3 commits November 28, 2023 12:30
Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
@krajorama krajorama enabled auto-merge (squash) November 28, 2023 12:01
@krajorama krajorama merged commit be77384 into release-2.10 Nov 28, 2023
28 checks passed
@krajorama krajorama deleted the krajo/backport-nativehistogram-docs-2.10 branch November 28, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants