-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.10] Backport native histograms documentation #6757
Merged
krajorama
merged 5 commits into
release-2.10
from
krajo/backport-nativehistogram-docs-2.10
Nov 28, 2023
Merged
[2.10] Backport native histograms documentation #6757
krajorama
merged 5 commits into
release-2.10
from
krajo/backport-nativehistogram-docs-2.10
Nov 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to release the docs sooner than 2.11. Removed mention of resolution reduction on ingest, since that is a 2.11 feature. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
osg-grafana
reviewed
Nov 28, 2023
docs/sources/mimir/configure/configure-native-histograms-ingestion.md
Outdated
Show resolved
Hide resolved
osg-grafana
reviewed
Nov 28, 2023
docs/sources/mimir/configure/configure-native-histograms-ingestion.md
Outdated
Show resolved
Hide resolved
osg-grafana
reviewed
Nov 28, 2023
|
||
To enable Prometheus remote write to send native histograms to Grafana Mimir, add the `send_native_histograms: true` parameter to your remote write configuration, for example: | ||
To limit the number of native histogram buckets per sample, set the `-validation.max-native-histogram-buckets` flag on distributors. | ||
The recommended value is 160 which is the default in the [OpenTelemetry SDK](https://opentelemetry.io/docs/specs/otel/metrics/sdk/) for exponential histograms, which are a similar concept in OpenTelemetry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
The recommended value is 160 which is the default in the [OpenTelemetry SDK](https://opentelemetry.io/docs/specs/otel/metrics/sdk/) for exponential histograms, which are a similar concept in OpenTelemetry. | |
The recommended value is `160`, which is the default in the [OpenTelemetry SDK](https://opentelemetry.io/docs/specs/otel/metrics/sdk/) for exponential histograms. The native histogram buckets are similar in concept to exponential histograms in OpenTelemetry. |
Spell out that last sentence. Please vet this for technical accuracy, because my change is a guess and has high potential for being inaccurate in this case.
Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
pstibrany
approved these changes
Nov 28, 2023
osg-grafana
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
We want to release the docs sooner than 2.11.
Removed mention of resolution reduction on ingest, since that is a 2.11 feature.
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.