Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of /ingester/push endpoint #6299

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Conversation

duricanikolic
Copy link
Contributor

@duricanikolic duricanikolic commented Oct 9, 2023

What this PR does

This PR gets rid of the /ingester/push endpoint. This endpoint was introduced for testing and debugging, and has not been used. Moreover, it is not a part of the documented public API. Therefore, it will be removed.

Which issue(s) this PR fixes or relates to

Related to Related to #6008

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
@duricanikolic duricanikolic requested a review from a team as a code owner October 9, 2023 12:16
@duricanikolic duricanikolic self-assigned this Oct 9, 2023
Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet.

@duricanikolic
Copy link
Contributor Author

Sweet.

@pstibrany could you please also merge this PR?

@pstibrany pstibrany merged commit 0ab5e5c into main Oct 9, 2023
28 checks passed
@pstibrany pstibrany deleted the yuri/get-rid-ingester-push branch October 9, 2023 12:38
@pstibrany
Copy link
Member

Sweet.

@pstibrany could you please also merge this PR?

Sure. I wanted to see if tests fail, but apparently it wasn't used by any 🎉

@colega
Copy link
Contributor

colega commented Oct 9, 2023

Even though it's not documented, I think this deserves a changelog entry. @duricanikolic can you send another PR please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants