Change default -blocks-storage.tsdb.series-hash-cache-max-size-bytes from 1GB to 350MB #6130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from 1GB to 350MB Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
deleted the
change-blocks-storage.tsdb.series-hash-cache-max-size-bytes
branch
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
When we introduced the series hash cache, we initially set the default
-blocks-storage.tsdb.series-hash-cache-max-size-bytessetting to a random number (1GB). In this PR I propose to upstream a config change we recently did at Grafana Labs and change the default setting to 350MB, which is enouch to store the hashes for all series queried from an ingester, assuming the 13h TSDB retention (default) and up to 2M in-memory series in the ingester.Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]