Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release notes for Mimir 2.10 #5873

Merged
merged 8 commits into from
Sep 4, 2023
Merged

Release notes for Mimir 2.10 #5873

merged 8 commits into from
Sep 4, 2023

Conversation

colega
Copy link
Contributor

@colega colega commented Aug 30, 2023

What this PR does

Publishes the release notes for Mimir 2.10.

Which issue(s) this PR fixes or relates to

#5849

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
@colega colega requested review from a team as code owners August 30, 2023 15:57
@colega colega mentioned this pull request Aug 30, 2023
3 tasks
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing, I left a couple of small suggestions

docs/sources/mimir/release-notes/v2.10.md Outdated Show resolved Hide resolved
docs/sources/mimir/release-notes/v2.10.md Outdated Show resolved Hide resolved
docs/sources/mimir/release-notes/v2.10.md Outdated Show resolved Hide resolved
docs/sources/mimir/release-notes/v2.10.md Outdated Show resolved Hide resolved
docs/sources/mimir/release-notes/v2.10.md Outdated Show resolved Hide resolved
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Co-authored-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@osg-grafana osg-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@colega
Copy link
Contributor Author

colega commented Aug 31, 2023

I see we've been repeating that for a few release notes now, I wonder if we should drop it or we should be explicit on that.

Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

docs/sources/mimir/release-notes/v2.10.md Outdated Show resolved Hide resolved
Copy link
Contributor

@krajorama krajorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing release notes about

[FEATURE] Ingester: add new metrics for tracking native histograms in active series: `cortex_ingester_active_native_histogram_series`, `cortex_ingester_active_native_histogram_series_custom_tracker`, `cortex_ingester_active_native_histogram_buckets`, `cortex_ingester_active_native_histogram_buckets_custom_tracker`. The first 2 are the subsets of the existing and unmodified `cortex_ingester_active_series` and `cortex_ingester_active_series_custom_tracker` respectively, only tracking native histogram series, and the last 2 are the equivalents for tracking the number of buckets in native histogram series. #5318

docs/sources/mimir/release-notes/v2.10.md Outdated Show resolved Hide resolved
@krajorama
Copy link
Contributor

I see we've been repeating that for a few release notes now, I wonder if we should drop it or we should be explicit on that.

I don't think it hurts to have a reference to the Helm chart. Least effort is to keep copying the sentence :)

colega and others added 2 commits September 1, 2023 11:00
Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com>
Co-authored-by: Marco Pracucci <marco@pracucci.com>
@colega
Copy link
Contributor Author

colega commented Sep 1, 2023

@krajorama I didn't include new metrics, etc. As they're not really user features but ways to monitor the deployment. Do you think we should include these explicitly?

@krajorama
Copy link
Contributor

@krajorama I didn't include new metrics, etc. As they're not really user features but ways to monitor the deployment. Do you think we should include these explicitly?

Hi @colega I think meta-monitoring and chargeback is a user feature , see for example https://grafana.com/docs/mimir/latest/operators-guide/monitor-grafana-mimir/ and https://grafana.com/docs/mimir/latest/configure/configure-custom-trackers/ . So yes I think it's worth mentioning.

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
@colega
Copy link
Contributor Author

colega commented Sep 4, 2023

@krajorama I've added them: 7662b01

@colega colega merged commit e0cbf9a into release-2.10 Sep 4, 2023
27 checks passed
@colega colega deleted the notes-release-2.10 branch September 4, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants