-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release notes for Mimir 2.10 #5873
Conversation
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for writing, I left a couple of small suggestions
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> Co-authored-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check with @krajorama about https://github.com/grafana/mimir/pull/5873/files#diff-7056e7f8e764ecb6c9252025d8ea49ef0a457eafcff49c998dbdc2e9a8b9696cR53. Otherwise, looks good. :)
I see we've been repeating that for a few release notes now, I wonder if we should drop it or we should be explicit on that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing release notes about
[FEATURE] Ingester: add new metrics for tracking native histograms in active series: `cortex_ingester_active_native_histogram_series`, `cortex_ingester_active_native_histogram_series_custom_tracker`, `cortex_ingester_active_native_histogram_buckets`, `cortex_ingester_active_native_histogram_buckets_custom_tracker`. The first 2 are the subsets of the existing and unmodified `cortex_ingester_active_series` and `cortex_ingester_active_series_custom_tracker` respectively, only tracking native histogram series, and the last 2 are the equivalents for tracking the number of buckets in native histogram series. #5318
I don't think it hurts to have a reference to the Helm chart. Least effort is to keep copying the sentence :) |
Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com>
Co-authored-by: Marco Pracucci <marco@pracucci.com>
@krajorama I didn't include new metrics, etc. As they're not really user features but ways to monitor the deployment. Do you think we should include these explicitly? |
Hi @colega I think meta-monitoring and chargeback is a user feature , see for example https://grafana.com/docs/mimir/latest/operators-guide/monitor-grafana-mimir/ and https://grafana.com/docs/mimir/latest/configure/configure-custom-trackers/ . So yes I think it's worth mentioning. |
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
@krajorama I've added them: 7662b01 |
What this PR does
Publishes the release notes for Mimir 2.10.
Which issue(s) this PR fixes or relates to
#5849
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]