Fix buffer-pooling ingester client #5830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
2 tasks
aknuds1
approved these changes
Aug 24, 2023
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
jhalterman
reviewed
Aug 24, 2023
| // return them to the pool. | ||
| wr.ReturnBuffersToPool() | ||
| } | ||
| return resp, err |
There was a problem hiding this comment.
Do buffers ever get returned to the pool in the case of an error? If not, is that a problem?
There was a problem hiding this comment.
No, they don't. When this optimization (buffering client) is disabled, then there's no buffer reuse at all, so overall this is still an improvement.
There was a problem hiding this comment.
If enough buffers are not returned to the pool, could it eventually become empty? Maybe instead of returning a buffer to the pool on error, you can inform the pool that it has an empty slot?
There was a problem hiding this comment.
Pool also starts empty. If an existing buffer cannot be retrieved from the pool, new buffer is allocated, and then put into the pool when not used anymore.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR fixes data race caused by using buffer-pooling ingester client, originally introduced in #5195. Before this PR the client would always return buffers to the pool. However in case of context cancellations buffers could still be enqueued for sending inside gRPC client, and returning them back to pool would cause data race.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]