Disable distributor.write-requests-buffer-pooling-enabled by default #5805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
colega
approved these changes
Aug 21, 2023
pracucci
approved these changes
Aug 21, 2023
pstibrany
deleted the
disable-distributor.write-requests-buffer-pooling-enabled
branch
pstibrany
added a commit
that referenced
this pull request
Aug 21, 2023
…5805) * Disable distributor.write-requests-buffer-pooling-enabled by default. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Add PR number. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> --------- Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
pstibrany
added a commit
that referenced
this pull request
Aug 21, 2023
…5805) * Disable distributor.write-requests-buffer-pooling-enabled by default. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Add PR number. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> --------- Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
This was referenced Aug 21, 2023
pstibrany
added a commit
that referenced
this pull request
Aug 21, 2023
* Revert PR 5389 to put back flags for disabling optimizations. (#5798) * Revert PR 5389 Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Enable distributor optimization by default, so that it works as before. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> --------- Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Disable distributor.write-requests-buffer-pooling-enabled by default (#5805) * Disable distributor.write-requests-buffer-pooling-enabled by default. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Add PR number. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> --------- Signed-off-by: Peter Štibraný <pstibrany@gmail.com> --------- Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
pstibrany
added a commit
that referenced
this pull request
Aug 21, 2023
* Revert PR 5389 to put back flags for disabling optimizations. (#5798) * Revert PR 5389 Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Enable distributor optimization by default, so that it works as before. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> --------- Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Disable distributor.write-requests-buffer-pooling-enabled by default (#5805) * Disable distributor.write-requests-buffer-pooling-enabled by default. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Add PR number. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> --------- Signed-off-by: Peter Štibraný <pstibrany@gmail.com> --------- Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
pstibrany
added a commit
that referenced
this pull request
Aug 21, 2023
…5805) * Disable distributor.write-requests-buffer-pooling-enabled by default. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Add PR number. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> --------- Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
pstibrany
added a commit
that referenced
this pull request
Aug 21, 2023
* Revert PR 5389 to put back flags for disabling optimizations. (#5798) * Revert PR 5389 Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Enable distributor optimization by default, so that it works as before. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> --------- Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Disable distributor.write-requests-buffer-pooling-enabled by default (#5805) * Disable distributor.write-requests-buffer-pooling-enabled by default. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Add PR number. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> --------- Signed-off-by: Peter Štibraný <pstibrany@gmail.com> --------- Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
We have found that this optimization causes race detector to report problems.
Until we fix the races, we're disabling the optimization.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]